shibd commented on code in PR #16279:
URL: https://github.com/apache/pulsar/pull/16279#discussion_r932995851
##########
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java:
##########
@@ -308,11 +308,20 @@ public static FunctionDetails convert(FunctionConfig
functionConfig, ExtractedFu
// windowing related
WindowConfig windowConfig = functionConfig.getWindowConfig();
if (windowConfig != null) {
+ // Windows Function not support EFFECTIVELY_ONCE
+ if (functionConfig.getProcessingGuarantees() ==
FunctionConfig.ProcessingGuarantees.EFFECTIVELY_ONCE) {
+ throw new IllegalArgumentException(
+ "Windows Function not support EFFECTIVELY_ONCE
delivery semantics.");
+ } else {
+ // Override functionConfig.getProcessingGuarantees to MANUAL,
and set windowsFunction is guarantees
+
windowConfig.setProcessingGuarantees(WindowConfig.ProcessingGuarantees
Review Comment:
Thanks, `WindowsFunction` does not support `MANUAL`, I will add some checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
