tisonkun commented on code in PR #16836:
URL: https://github.com/apache/pulsar/pull/16836#discussion_r933336852
##########
.github/workflows/semantic.yaml:
##########
@@ -0,0 +1,35 @@
+name: "PR Lint"
+
+on:
+ pull_request_target:
+ types:
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ main:
+ name: Validate PR title
+ runs-on: ubuntu-latest
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v3
+ with:
+ submodules: recursive
+ - uses: amannn/action-semantic-pull-request@v4
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ [feat]
+ [fix]
+ [docs]
Review Comment:
Cherry pick my comment from the gdoc proposal/document:
When working on https://github.com/apache/pulsar/pull/16836 you may find the
standard https://www.conventionalcommits.org/ uses form:
> type(component):
What if we just follow the existing standard instead of creating a new one?
That will satisfy all contributors already familiar to conventional commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
