RobertIndie commented on PR #16838: URL: https://github.com/apache/pulsar/pull/16838#issuecomment-1200111973
> Generally looks good. May I ask why you change `return` to `System.exit`? This is a bug that I fixed in passing because it will affect this PR: Even after the standalone detects a config file setting error, it does not let the program exit but will continue to run. It doesn't stop until a subsequent error when loading the configuration file. ``` 2022-07-30T15:52:28,490+0800 [main] ERROR org.apache.pulsar.PulsarStandaloneStarter - Expected a value after parameter -c 2022-07-30T15:52:28,527+0800 [main] INFO org.apache.pulsar.PulsarStandalone - Found existing ZooKeeper metadata. Continuing with ZooKeeper 2022-07-30T15:52:28,527+0800 [main] ERROR org.apache.pulsar.PulsarStandalone - Failed to load configuration ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
