Jason918 commented on code in PR #16325:
URL: https://github.com/apache/pulsar/pull/16325#discussion_r933789130
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactoryImpl.java:
##########
@@ -71,9 +71,7 @@ public BookKeeper create(ServiceConfiguration conf,
MetadataStoreExtended store,
MetadataDrivers.registerClientDriver("metadata-store",
PulsarMetadataClientDriver.class);
ClientConfiguration bkConf = createBkClientConfiguration(store, conf);
- if (properties != null) {
- properties.forEach((key, value) -> bkConf.setProperty(key, value));
- }
+
Review Comment:
I understand that removing `properties` here can solve current isolation
issue. My concern is that if this `properties` is introduced only to support
isolation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
