eolivelli commented on code in PR #16816:
URL: https://github.com/apache/pulsar/pull/16816#discussion_r933801289


##########
site2/docs/functions-develop-api.md:
##########
@@ -102,6 +102,39 @@ public class ExclamationFunction implements 
Function<String, String> {
 
 For more details, see [code 
example](https://github.com/apache/pulsar/blob/master/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/ExclamationFunction.java).
 
+The return type of the `Function` can be wrapped in a Pulsar `Record` generic 
which gives more control on the output message (topic, schema, properties, ...)
+You can use the `Context::newOutputRecordBuilder` method to build this 
`Record` output.

Review Comment:
   I would say you 'must' and not you 'can'. (Even if we don't enforce that in 
the code)
   This is stronger and we really don't want users to build their own 
implementations of Record.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to