coderzc opened a new pull request, #16887:
URL: https://github.com/apache/pulsar/pull/16887
Fixes #16567
### Motivation
When PartitionedConsumer is closed, it forgets to close `messages_` leading
to the PartitionedConsumer blocking operations can't be interrupted.
Also, we should return `ResultAlreadyClosed` rather than `ResultTimeout`
when `state_ != Ready` after `message_.pop()` failed.
### Modifications
* Close `messages_` when PartitionedConsumer is closed.
* Return `ResultAlreadyClosed` when `state_ != Ready` after `message_.pop()`
failed.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as
*testPartitionsWithCloseUnblock*.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
