eolivelli commented on code in PR #16605:
URL: https://github.com/apache/pulsar/pull/16605#discussion_r933930478
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReaderTest.java:
##########
@@ -1096,7 +1096,6 @@ public void testHasMessageAvailableWithBatch() throws
Exception {
ReaderImpl<byte[]> reader =
(ReaderImpl<byte[]>)pulsarClient.newReader().topic(topicName)
.startMessageId(messageId).startMessageIdInclusive().create();
MessageIdImpl lastMsgId = (MessageIdImpl)
reader.getConsumer().getLastMessageId();
- assertTrue(messageId instanceof BatchMessageIdImpl);
Review Comment:
Please change the name of the method then
@codelipenghui FYI
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdProduce.java:
##########
@@ -147,6 +148,7 @@ public class CmdProduce {
private ClientBuilder clientBuilder;
private Authentication authentication;
private String serviceURL;
+ private List<MessageId> messageIds = new ArrayList<>();
Review Comment:
This list will become huge when you use this tool in real world.
If you need to catch the messages you are sending you can use mockito and
override the 'send' method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
