asafm commented on issue #16680: URL: https://github.com/apache/pulsar/issues/16680#issuecomment-1200406660
Ok, regarding the memory I see that `canEnqueueRequest` makes sure we're not breaching memory limits for the client prior to insertion. Regarding the actual implementation, I'm a bit puzzled. Why re-use BatchMessageContainerImpl which was geared towards a single batch and make it multi batch? Why not do like the BatchMessageKeyBasedContainer and create your own? You wrote that it will send messages out of order, but once you batch them in separate batches concurrently , this by design will make them out of order no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
