[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16890: [feature][broker] offloader the data by topic compacted

Sun, 31 Jul 2022 20:19:58 -0700 


Technoboy- commented on code in PR #16890:
URL: https://github.com/apache/pulsar/pull/16890#discussion_r934108472


##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixReadTest.java:
##########
@@ -231,6 +235,11 @@ public CompletableFuture<Void> offload(ReadHandle ledger,
             return promise;
         }
 
+        @Override
+        public CompletableFuture<Void> offload(ByteBuf buf, long ledgerId, 
String topicName, UUID uid) {
+            return null;

Review Comment:
   CompletableFuture.completedFuture(null);



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to