sijie commented on a change in pull request #4129: [pulsar-flink] Add
subscription initial position
URL: https://github.com/apache/pulsar/pull/4129#discussion_r278400399
##########
File path:
pulsar-flink/src/test/java/org/apache/flink/streaming/connectors/pulsar/PulsarSourceBuilderTest.java
##########
@@ -112,6 +114,11 @@ public void testSubscriptionNameWithBlank() {
pulsarSourceBuilder.subscriptionName(" ");
}
+ @Test(expectedExceptions = IllegalArgumentException.class)
Review comment:
hmm, shouldn't this be NullPointerException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
