tisonkun commented on code in PR #16836:
URL: https://github.com/apache/pulsar/pull/16836#discussion_r935100493
##########
.github/workflows/semantic.yaml:
##########
@@ -0,0 +1,35 @@
+name: "PR Lint"
+
+on:
+ pull_request_target:
+ types:
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ main:
+ name: Validate PR title
+ runs-on: ubuntu-latest
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v3
+ with:
+ submodules: recursive
+ - uses: amannn/action-semantic-pull-request@v4
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ [feat]
+ [fix]
+ [docs]
Review Comment:
After an offline discussion with @Anonymitaet & @nodece we noticed that
`action-semantic-pull-request` can define its own pattern to catch up on type,
scope, and subject (`headerPattern`). So the technical part is not a blocker.
@dave2wave I agree that committers should help correct the title and help
contributors to get used to the conventions. That's how I act as a committer in
other projects.
BTW, enforcing such rules will significantly change contributors' experience
so we should vote on the dev@ mailing list with an inline proposal (instead of
a gdoc out of control to PMC).
The proposal doesn't need to be too long, but a brief motivation, the
pattern proposed (including types, scopes in dropdown list), implementation and
existing workflows/conventions depend on it. (For example, RM can generate
release note based on the pattern)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
