poorbarcode commented on code in PR #16758:
URL: https://github.com/apache/pulsar/pull/16758#discussion_r936661727
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java:
##########
@@ -89,15 +89,15 @@
/**
* Caches “write requests” for a certain for a certain number, if reach
this threshold, will trig Bookie writes.
*/
- private final int batchedWriteMaxRecords;
+ final int batchedWriteMaxRecords;
Review Comment:
> What's the motivation for the removal of private from these three
variables?
These changes have been restored. Thanks
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java:
##########
@@ -89,15 +89,15 @@
/**
* Caches “write requests” for a certain for a certain number, if reach
this threshold, will trig Bookie writes.
*/
- private final int batchedWriteMaxRecords;
+ final int batchedWriteMaxRecords;
Review Comment:
These changes have been restored. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
