poorbarcode commented on code in PR #16758: URL: https://github.com/apache/pulsar/pull/16758#discussion_r937021228
########## pulsar-transaction/coordinator/src/test/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriterTest.java: ########## @@ -60,8 +61,14 @@ import org.testng.annotations.Test; @Slf4j +@Test(groups = "broker") Review Comment: > General comment: The test below don't check each case of trigger. I would expect each scenario to check the metrics to the correct ones. I wouldn't make up a test method to check the metrics which half of them are not really relevant. If you have a scenario for batchRecordCount > max records flush, then check metric there, no? Thanks, I have split the method `testMetricsStatsWhenDisabledBatchFeature` to this 4 method: - `testMetricsStatsThatTriggeredByMaxRecordCount` - `testMetricsStatsThatTriggeredByMaxSize` - `testMetricsStatsThatTriggeredByMaxDelayTime` - `testMetricsStatsThatTriggeredByLargeSingleData` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
