heesung-sn commented on code in PR #16937:
URL: https://github.com/apache/pulsar/pull/16937#discussion_r937326195
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java:
##########
@@ -86,14 +109,13 @@ public Multimap<String, String>
findBundlesForUnloading(final LoadData loadData,
double minimumThroughputToOffload = brokerCurrentThroughput *
percentOfTrafficToOffload;
if (minimumThroughputToOffload < minThroughputThreshold) {
- if (log.isDebugEnabled()) {
- log.debug("[{}] broker is planning to shed throughput {}
MByte/s less than "
+ if (sampleLog) {
Review Comment:
I intentionally sample the logs as this shedding logic computes the load
frequently every x min(I think the default is every one minute).
Here, we want to emit logs for every unload decision (as-is) but sample logs
for the skip(non-unload) decisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
