nodece commented on code in PR #16792:
URL: https://github.com/apache/pulsar/pull/16792#discussion_r938428577
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java:
##########
@@ -392,23 +392,6 @@ public CompletableFuture<Boolean>
checkPermission(TopicName topicName, String ro
return true;
}
}
-
Review Comment:
@TakaHiR07 There are five scenarios:
1. Grant permission
Based on `topicName.getPartitionedTopicName()`
2. Revoke permission
Based on `topicName.getPartitionedTopicName()`, and full name of each
partition topic(my-topic-partition-0, my-topic-partition-1, ....)
4. Get permission
Based on `topicName.getPartitionedTopicName()`, and full name of each
partition topic(my-topic-partition-0, my-topic-partition-1, ....)
5. Check permission
Based on `topicName.getPartitionedTopicName()`, and full name of each
partition topic(my-topic-partition-0, my-topic-partition-1, ....)
Using the above rule can meet the old and new versions, no matter how the
user grants permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
