equanz opened a new pull request, #822: URL: https://github.com/apache/pulsar-client-go/pull/822
### Motivation Package private functions, defined in `pulsar/test_helper.go`, are called from test codes. However, it is recognized as a non-test code by Go Modules because it doesn't follow the test code naming convention. This issue causes a dependency for the test is recognized as a non-test dependency. Therefore, test dependency is linked as one of the transitive dependencies when using this module. ``` % git --no-pager show HEAD --no-patch commit bd19458b32ff89206c135cc647336e690e99c32f (HEAD -> master, apache/master, apache/HEAD) Author: ming <[email protected]> Date: Fri Jul 29 01:00:33 2022 -0400 ... % go list -deps | grep testify github.com/stretchr/testify/assert ``` ### Modifications Rename `pulsar/test_helper.go` to follow test code naming convention. ``` % git --no-pager show HEAD --no-patch commit d0242a510ae7574011b549bf6d655833be93d197 (HEAD -> rename_helper, origin/rename_helper) Author: equanz <[email protected]> Date: Sun Aug 7 09:13:12 2022 +0900 ... % go list -deps | grep testify ``` ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) ### Documentation - Does this pull request introduce a new feature? (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
