RobertIndie commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r939897369
##########
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##########
@@ -54,6 +55,39 @@
MultiTopicsConsumerImpl::MultiTopicsConsumerImpl(ClientImplPtr client, const std
}
}
+MultiTopicsConsumerImpl::MultiTopicsConsumerImpl(ClientImplPtr client, const
std::string singleTopic,
Review Comment:
Creating another constructor just for the MultiTopicsConsumer seems to
create a lot of duplicate codes. I think we can create a static method to
create a partitioned topic consumer based on the multi topics consumer.
##########
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##########
@@ -363,13 +401,12 @@ void MultiTopicsConsumerImpl::closeAsync(ResultCallback
callback) {
auto self = shared_from_this();
int numConsumers = 0;
- consumers_.forEach(
- [&numConsumers, &self, callback](const std::string& name, const
ConsumerImplPtr& consumer) {
- numConsumers++;
- consumer->closeAsync([self, name, callback](Result result) {
- self->handleSingleConsumerClose(result, name, callback);
- });
+ for (const auto& item : consumers_.toPairVector()) {
Review Comment:
The effect of these traversal methods looks the same. BTW, `toPairVector` is
marked with 'only used for tests'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
