asafm commented on code in PR #16758:
URL: https://github.com/apache/pulsar/pull/16758#discussion_r939988061
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java:
##########
@@ -541,8 +539,53 @@ public void recycle(){
this.asyncAddArgsList.clear();
this.handle.recycle(this);
}
+
+ public void addCallback(AddDataCallback callback, Object ctx){
+ AsyncAddArgs asyncAddArgs = AsyncAddArgs.newInstance(callback,
ctx, System.currentTimeMillis());
+ asyncAddArgsList.add(asyncAddArgs);
+ }
}
+ /** Callback for batch write BK. **/
+ private final BufferedAddEntryCallback bufferedAddEntryCallback = new
BufferedAddEntryCallback();
Review Comment:
Let's place this together with all class variables in the beginning of the
class
Again, comments: `/** Callback for batch write BK. **/` then
`bufferedAddEntryCallback` --> `bookKeeperBatchedWriteCallback`
then delete comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
