codelipenghui commented on code in PR #16824: URL: https://github.com/apache/pulsar/pull/16824#discussion_r940072485
########## conf/broker.conf: ########## @@ -1264,10 +1264,10 @@ replicatorPrefix=pulsar.repl # due to missing ZooKeeper watch (disable with value 0) replicationPolicyCheckDurationSeconds=600 -# Default message retention time +# Default message retention time. Using a value of -1, is disabling message retention time limit defaultRetentionTimeInMinutes=0 -# Default retention size +# Default retention size. Using a value of -1, is disabling message retention size limit Review Comment: I think it's not correct. 0 means the retention is disabled, -1 means the data will not be removed by time or size quota? I think we can change to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
