AnonHxy commented on code in PR #16824: URL: https://github.com/apache/pulsar/pull/16824#discussion_r940946822
########## conf/broker.conf: ########## @@ -1264,10 +1264,10 @@ replicatorPrefix=pulsar.repl # due to missing ZooKeeper watch (disable with value 0) replicationPolicyCheckDurationSeconds=600 -# Default message retention time +# Default message retention time. Using a value of -1, is disabling message retention time limit defaultRetentionTimeInMinutes=0 -# Default retention size +# Default retention size. Using a value of -1, is disabling message retention size limit Review Comment: Great. I find this PR https://github.com/apache/pulsar/pull/16572 has already fix partial of the problem. But the description in the doc maybe not clear enought, e. g, : - https://github.com/apache/pulsar/blob/f02679d83402ac07e06c48570505f343e350a491/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java#L2382 `will not be removed by time or size quota` is better I think - https://github.com/apache/pulsar/blob/f02679d83402ac07e06c48570505f343e350a491/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java#L2388 `no infinite size quota` should be `infinite size quota` So I also rewrite it as what you mentioned above. @codelipenghui . PTAL also @Anonymitaet ~ thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
