[GitHub] [pulsar] mattisonchao commented on a diff in pull request #16996: [fix][broker] Fix memory leak if entry exists in cache

Tue, 09 Aug 2022 00:46:31 -0700 


mattisonchao commented on code in PR #16996:
URL: https://github.com/apache/pulsar/pull/16996#discussion_r941011425


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java:
##########
@@ -211,13 +211,8 @@ public void safeRun() {
         if (ml.hasActiveCursors()) {
             // Avoid caching entries if no cursor has been created
             EntryImpl entry = EntryImpl.create(ledger.getId(), entryId, data);

Review Comment:
   Question: Does the `data` need to release? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to