michaeljmarshall opened a new pull request, #17029:
URL: https://github.com/apache/pulsar/pull/17029

   Fixes https://github.com/apache/pulsar/issues/17028 
https://github.com/apache/pulsar/issues/16830
   
   ### Motivation
   
   In #16968, there was a change to remove some logic that appears necessary 
for certain message delivery guarantees. This PR fixes the minor regression 
introduced in that PR.
   
   ### Modifications
   
   * Set `sendInProgress = true` before dispatching the read request
   * Wrap two method calls with a `synchronized` block to return the original 
semantics from before #16968
   
   ### Verifying this change
   
   I verified that both `testDelayedDeliveryWithMultipleConcurrentReadEntries` 
and `testMessageRedelivery` pass consistently. Both were failing on my machine 
and stopped failing when I set `sendInProgress = true`. 
   
   ### Documentation
     
   - [x] `doc-not-needed` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to