Anonymitaet commented on code in PR #16746:
URL: https://github.com/apache/pulsar/pull/16746#discussion_r941949896
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -181,9 +181,11 @@
* Set the timeout for unacked messages, truncated to the nearest
millisecond. The timeout needs to be greater than
* 1 second.
*
- * <p>By default, the acknowledge timeout is disabled and that means that
messages delivered to a
- * consumer is not re-delivered unless the consumer crashes. Since 2.3.0,
when a dead letter policy
- * is specified, and no ackTimeoutMillis is specified, the ack timeout is
set to 30 seconds.
+ * <p>By default, the acknowledge timeout is disabled (set to ‘0’ which
means no limit).
+ * When a consumer with an infinite acknowledgment timeout terminates, any
unacknowledged
+ * messages that it receives are re-delivered to another consumer.
+ * Since 2.3.0, when a dead letter policy is specified and no
ackTimeoutMillis is specified,
+ * the ack timeout is set to 30 seconds.
Review Comment:
Have you run checks to test line 184-188? Can we use ’’ in code description?
What does the preview look like？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
