lhotari opened a new pull request, #17043:
URL: https://github.com/apache/pulsar/pull/17043

   ### Motivation
   
   - counters could get off a lot when many consumers are reconnecting from 
time to time
   
   ### Additional context
   
   Pulsar increments the counters when the sending is scheduled. Since the 
dispatching code is asynchronous, it behaves in a way that Pulsar will try to 
consume all permits and queue as much of messages as possible. Since the 
counters are incremented before the messages have been written to the TCP/IP 
socket, this will result in the counters getting out of sync when the 
connection is disconnected.
   
   ### Modifications
   
   - increment counters and update rate after the messages have been 
successfully written to the TCP/IP connection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to