poorbarcode commented on code in PR #16758:
URL: https://github.com/apache/pulsar/pull/16758#discussion_r942608269
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java:
##########
@@ -546,10 +552,9 @@ public void addCallback(AddDataCallback callback, Object
ctx){
}
}
- /** Callback for batch write BK. **/
- private final BufferedAddEntryCallback bufferedAddEntryCallback = new
BufferedAddEntryCallback();
+ private final BookKeeperBatchedWriteCallback
bookKeeperBatchedWriteCallback = new BookKeeperBatchedWriteCallback();
- private class BufferedAddEntryCallback implements
AsyncCallbacks.AddEntryCallback{
+ private class BookKeeperBatchedWriteCallback implements
AsyncCallbacks.AddEntryCallback{
Review Comment:
Yes, `BookKeeperBatchedWriteCallback` accessed the method
`failureCallbackByContextAndRecycle` and `managedLedger`. I tried make
`failureCallbackByContextAndRecycle` to `static`, but this method also used
`managedLedger`. both of them used `managedLedger` to print logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
