merlimat commented on a change in pull request #4062: Delayed message delivery
implementation
URL: https://github.com/apache/pulsar/pull/4062#discussion_r279045252
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -271,9 +275,13 @@ public void recordLatency(EventType eventType, long
latencyMs) {
pulsarStats.recordZkLatencyTimeValue(eventType, latencyMs);
}
};
+
+ this.delayedDeliveryTrackerFactory = DelayedDeliveryTrackerLoader
+ .loadDelayedDeliveryTrackerFactory(pulsar.getConfiguration());
}
public void start() throws Exception {
+
this.delayedDeliveryTrackerFactory.initialize(pulsar.getConfiguration());
Review comment:
Yes, I moved the initialize on the start() but that's not consistent with
other classes. I'll change it back to call initialize immediately after the
class is instantiated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
