codelipenghui commented on code in PR #17056:
URL: https://github.com/apache/pulsar/pull/17056#discussion_r943266412
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorTest.java:
##########
@@ -737,6 +738,69 @@ public void testBacklogStatsWhenDroppingData() throws
Exception {
ledger.close();
}
+ @Test
+ public void testInvalidateReadHandleWithSlowNonDurableCursor() throws
Exception {
+ ManagedLedgerImpl ledger = (ManagedLedgerImpl)
factory.open("testInvalidateReadHandleWithSlowNonDurableCursor",
+ new
ManagedLedgerConfig().setMaxEntriesPerLedger(1).setRetentionTime(-1,
TimeUnit.SECONDS)
+ .setRetentionSizeInMB(-1));
+ ManagedCursor c1 = ledger.openCursor("c1");
+ ManagedCursor nonDurableCursor =
ledger.newNonDurableCursor(PositionImpl.EARLIEST);
Review Comment:
Looks like we don't need a real non-durable cursor?
Just update the `SlowestNonDurableReadPosition`
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorTest.java:
##########
@@ -737,6 +738,69 @@ public void testBacklogStatsWhenDroppingData() throws
Exception {
ledger.close();
}
+ @Test
+ public void testInvalidateReadHandleWithSlowNonDurableCursor() throws
Exception {
+ ManagedLedgerImpl ledger = (ManagedLedgerImpl)
factory.open("testInvalidateReadHandleWithSlowNonDurableCursor",
+ new
ManagedLedgerConfig().setMaxEntriesPerLedger(1).setRetentionTime(-1,
TimeUnit.SECONDS)
+ .setRetentionSizeInMB(-1));
+ ManagedCursor c1 = ledger.openCursor("c1");
+ ManagedCursor nonDurableCursor =
ledger.newNonDurableCursor(PositionImpl.EARLIEST);
+
+ assertEquals(nonDurableCursor.getNumberOfEntries(), 0);
+ assertEquals(nonDurableCursor.getNumberOfEntriesInBacklog(true), 0);
+
+ List<Position> positions = new ArrayList<>();
+ for (int i = 0; i < 10; i++) {
+ positions.add(ledger.addEntry(("entry-" + i).getBytes(UTF_8)));
+ }
+
+ CountDownLatch latch = new CountDownLatch(10);
+ for (int i = 0; i < 10; i++) {
+ ledger.asyncReadEntry((PositionImpl) positions.get(i), new
AsyncCallbacks.ReadEntryCallback() {
+ @Override
+ public void readEntryComplete(Entry entry, Object ctx) {
+ latch.countDown();
+ }
+
+ @Override
+ public void readEntryFailed(ManagedLedgerException exception,
Object ctx) {
+ latch.countDown();
+ }
+ }, null);
+ }
+
+ latch.await();
+
+
ledger.updateTheSlowestNonDurableReadPosition(nonDurableCursor.getReadPosition());
+ c1.markDelete(positions.get(4));
+
+ CompletableFuture<Void> promise = new CompletableFuture<>();
+ ledger.internalTrimConsumedLedgers(promise);
+ promise.join();
+
+ Assert.assertTrue(ledger.ledgerCache.containsKey(3));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(4));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(5));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(6));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(7));
+
+ promise = new CompletableFuture<>();
+
+ nonDurableCursor.markDelete(positions.get(3));
+
ledger.updateTheSlowestNonDurableReadPosition(nonDurableCursor.getReadPosition());
Review Comment:
Do we need this line? Looks the read position will not change.
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorTest.java:
##########
@@ -737,6 +738,69 @@ public void testBacklogStatsWhenDroppingData() throws
Exception {
ledger.close();
}
+ @Test
+ public void testInvalidateReadHandleWithSlowNonDurableCursor() throws
Exception {
+ ManagedLedgerImpl ledger = (ManagedLedgerImpl)
factory.open("testInvalidateReadHandleWithSlowNonDurableCursor",
+ new
ManagedLedgerConfig().setMaxEntriesPerLedger(1).setRetentionTime(-1,
TimeUnit.SECONDS)
+ .setRetentionSizeInMB(-1));
+ ManagedCursor c1 = ledger.openCursor("c1");
+ ManagedCursor nonDurableCursor =
ledger.newNonDurableCursor(PositionImpl.EARLIEST);
+
+ assertEquals(nonDurableCursor.getNumberOfEntries(), 0);
+ assertEquals(nonDurableCursor.getNumberOfEntriesInBacklog(true), 0);
+
+ List<Position> positions = new ArrayList<>();
+ for (int i = 0; i < 10; i++) {
+ positions.add(ledger.addEntry(("entry-" + i).getBytes(UTF_8)));
+ }
+
+ CountDownLatch latch = new CountDownLatch(10);
+ for (int i = 0; i < 10; i++) {
+ ledger.asyncReadEntry((PositionImpl) positions.get(i), new
AsyncCallbacks.ReadEntryCallback() {
+ @Override
+ public void readEntryComplete(Entry entry, Object ctx) {
+ latch.countDown();
+ }
+
+ @Override
+ public void readEntryFailed(ManagedLedgerException exception,
Object ctx) {
+ latch.countDown();
+ }
+ }, null);
+ }
+
+ latch.await();
+
+
ledger.updateTheSlowestNonDurableReadPosition(nonDurableCursor.getReadPosition());
+ c1.markDelete(positions.get(4));
+
+ CompletableFuture<Void> promise = new CompletableFuture<>();
+ ledger.internalTrimConsumedLedgers(promise);
+ promise.join();
+
+ Assert.assertTrue(ledger.ledgerCache.containsKey(3));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(4));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(5));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(6));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(7));
+
+ promise = new CompletableFuture<>();
+
+ nonDurableCursor.markDelete(positions.get(3));
+
ledger.updateTheSlowestNonDurableReadPosition(nonDurableCursor.getReadPosition());
+
+ ledger.internalTrimConsumedLedgers(promise);
+ promise.join();
+
+ Assert.assertFalse(ledger.ledgerCache.containsKey(3));
+ Assert.assertFalse(ledger.ledgerCache.containsKey(4));
+ Assert.assertFalse(ledger.ledgerCache.containsKey(5));
+ Assert.assertFalse(ledger.ledgerCache.containsKey(6));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(7));
+
Review Comment:
And we should continue to update the `SlowestNonDurableReadPosition` to make
sure the read handle cache can be invalidated
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorTest.java:
##########
@@ -737,6 +738,69 @@ public void testBacklogStatsWhenDroppingData() throws
Exception {
ledger.close();
}
+ @Test
+ public void testInvalidateReadHandleWithSlowNonDurableCursor() throws
Exception {
+ ManagedLedgerImpl ledger = (ManagedLedgerImpl)
factory.open("testInvalidateReadHandleWithSlowNonDurableCursor",
+ new
ManagedLedgerConfig().setMaxEntriesPerLedger(1).setRetentionTime(-1,
TimeUnit.SECONDS)
+ .setRetentionSizeInMB(-1));
+ ManagedCursor c1 = ledger.openCursor("c1");
+ ManagedCursor nonDurableCursor =
ledger.newNonDurableCursor(PositionImpl.EARLIEST);
+
+ assertEquals(nonDurableCursor.getNumberOfEntries(), 0);
+ assertEquals(nonDurableCursor.getNumberOfEntriesInBacklog(true), 0);
+
+ List<Position> positions = new ArrayList<>();
+ for (int i = 0; i < 10; i++) {
+ positions.add(ledger.addEntry(("entry-" + i).getBytes(UTF_8)));
+ }
+
+ CountDownLatch latch = new CountDownLatch(10);
+ for (int i = 0; i < 10; i++) {
+ ledger.asyncReadEntry((PositionImpl) positions.get(i), new
AsyncCallbacks.ReadEntryCallback() {
+ @Override
+ public void readEntryComplete(Entry entry, Object ctx) {
+ latch.countDown();
+ }
+
+ @Override
+ public void readEntryFailed(ManagedLedgerException exception,
Object ctx) {
+ latch.countDown();
+ }
+ }, null);
+ }
+
+ latch.await();
+
+
ledger.updateTheSlowestNonDurableReadPosition(nonDurableCursor.getReadPosition());
+ c1.markDelete(positions.get(4));
+
+ CompletableFuture<Void> promise = new CompletableFuture<>();
+ ledger.internalTrimConsumedLedgers(promise);
+ promise.join();
+
+ Assert.assertTrue(ledger.ledgerCache.containsKey(3));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(4));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(5));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(6));
+ Assert.assertTrue(ledger.ledgerCache.containsKey(7));
Review Comment:
We should avoid to use the hardcode ledger ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
