poorbarcode commented on code in PR #17033:
URL: https://github.com/apache/pulsar/pull/17033#discussion_r944466095
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -478,16 +478,13 @@ protected void
internalDeleteNamespaceForcefully(AsyncResponse asyncResponse, bo
if (topicName.isPartitioned()) {
String partitionedTopic =
topicName.getPartitionedTopicName();
if (!partitionedTopics.contains(partitionedTopic))
{
- // Distinguish partitioned topic to avoid
duplicate deletion of the same schema
-
topicFutures.add(pulsar().getAdminClient().topics().deletePartitionedTopicAsync(
- partitionedTopic, true, true));
partitionedTopics.add(partitionedTopic);
}
} else {
-
topicFutures.add(pulsar().getAdminClient().topics().deleteAsync(
- topic, true, true));
nonPartitionedTopics.add(topic);
}
+
topicFutures.add(pulsar().getAdminClient().topics().deleteAsync(
Review Comment:
+1
param "deleteSchema" of API `delete topic` has been removed in PR #14608.
<img width="1014" alt="截屏2022-08-12 21 30 20"
src="https://user-images.githubusercontent.com/25195800/184364237-71d0d154-0b1e-401e-9c9c-7aa958f4b04c.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/25195800/184364237-71d0d154-0b1e-401e-9c9c-7aa958f4b04c.png"](https://user-images.githubusercontent.com/25195800/184364237-71d0d154-0b1e-401e-9c9c-7aa958f4b04c.png"){kind=link}