tisonkun commented on code in PR #16993:
URL: https://github.com/apache/pulsar/pull/16993#discussion_r945935655
##########
pulsar-broker/pom.xml:
##########
@@ -425,6 +425,25 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.gaul</groupId>
+ <artifactId>modernizer-maven-plugin</artifactId>
+ <configuration>
+ <failOnViolations>false</failOnViolations>
Review Comment:
Is it possible we turn this option to `true` and exclude classes we don't
handle yet?
I'd prefer we enable the checker and gradually remove the exclusion instead
of keeping the check dry-run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
