michaeljmarshall commented on code in PR #16932:
URL: https://github.com/apache/pulsar/pull/16932#discussion_r945956785
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java:
##########
@@ -748,6 +749,20 @@ public void updateRates(NamespaceStats nsStats,
NamespaceBundleStats bundleStats
topicStatsStream.writePair("msgThroughputOut",
subMsgThroughputOut);
topicStatsStream.writePair("msgRateRedeliver",
subMsgRateRedeliver);
topicStatsStream.writePair("type",
subscription.getTypeString());
+
+ // Write entry filter stats
+ Dispatcher dispatcher0 = subscription.getDispatcher();
+ if (null != dispatcher0) {
+ topicStatsStream.writePair("entryFilterProcessedMsgs",
+ dispatcher0.getFilterProcessedMsgCount());
+ topicStatsStream.writePair("entryFilterAcceptedMsgs",
+ dispatcher0.getFilterAcceptedMsgCount());
+ topicStatsStream.writePair("entryFilterRejectedMsgs",
+ dispatcher0.getFilterRejectedMsgCount());
+ topicStatsStream.writePair("entryFilterRescheduledMsgs",
+ dispatcher0.getFilterRescheduledMsgCount());
Review Comment:
We use `MsgCount` elsewhere, and it'd be great to make it consistent. Also,
I don't think we need the `entry` filter prefix.
```suggestion
topicStatsStream.writePair("filterProcessedMsgCount",
dispatcher0.getFilterProcessedMsgCount());
topicStatsStream.writePair("filterAcceptedMsgCount",
dispatcher0.getFilterAcceptedMsgCount());
topicStatsStream.writePair("filterRejectedMsgCount",
dispatcher0.getFilterRejectedMsgCount());
topicStatsStream.writePair("filterRescheduledMsgCount",
dispatcher0.getFilterRescheduledMsgCount());
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1756,6 +1756,19 @@ public void updateRates(NamespaceStats nsStats,
NamespaceBundleStats bundleStats
topicStatsStream.writePair("totalNonContiguousDeletedMessagesRange",
subscription.getTotalNonContiguousDeletedMessagesRange());
topicStatsStream.writePair("type",
subscription.getTypeString());
+
+ Dispatcher dispatcher0 = subscription.getDispatcher();
+ if (null != dispatcher0) {
+ topicStatsStream.writePair("entryFilterProcessedMsgs",
+ dispatcher0.getFilterProcessedMsgCount());
+ topicStatsStream.writePair("entryFilterAcceptedMsgs",
+ dispatcher0.getFilterAcceptedMsgCount());
+ topicStatsStream.writePair("entryFilterRejectedMsgs",
+ dispatcher0.getFilterRejectedMsgCount());
+ topicStatsStream.writePair("entryFilterRescheduledMsgs",
+ dispatcher0.getFilterRescheduledMsgCount());
Review Comment:
Same suggestion.
```suggestion
topicStatsStream.writePair("filterProcessedMsgCount",
dispatcher0.getFilterProcessedMsgCount());
topicStatsStream.writePair("filterAcceptedMsgCount",
dispatcher0.getFilterAcceptedMsgCount());
topicStatsStream.writePair("filterRejectedMsgCount",
dispatcher0.getFilterRejectedMsgCount());
topicStatsStream.writePair("filterRescheduledMsgCount",
dispatcher0.getFilterRescheduledMsgCount());
```
##########
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/SubscriptionStatsImpl.java:
##########
@@ -137,6 +137,14 @@ public class SubscriptionStatsImpl implements
SubscriptionStats {
/** SubscriptionProperties (key/value strings) associated with this
subscribe. */
public Map<String, String> subscriptionProperties;
+ public long throughFilterMsgCount;
Review Comment:
```suggestion
public long filterProcessedMsgCount;
```
##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/SubscriptionStats.java:
##########
@@ -126,4 +126,12 @@ public interface SubscriptionStats {
/** The serialized size of non-contiguous deleted messages ranges. */
int getNonContiguousDeletedMessagesRangesSerializedSize();
+
+ long getThroughFilterMsgCount();
Review Comment:
```suggestion
long getFilterProcessedMsgCount();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
