Gleiphir2769 opened a new issue, #17110:
URL: https://github.com/apache/pulsar/issues/17110

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) 
and found nothing similar.
   
   
   ### Version
   
   Pulsar version: 2.10
   
   ### Minimal reproduce step
   
   It's a code bug.
   
   ### What did you expect to see?
   
   
https://github.com/apache/pulsar/blob/56c41f88600c9c1812fc9656283d159e18cad13a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L2665-L2689
   The parameter `autoAck` of `removeChunkMessage` is used to control whether 
the messages in `chunkedMsgCtx` are acked when `chunkedMsgCtx` is removed. The 
`removeChunkMessage` is invoked by `removeOldestPendingChunkedMessage` and 
`removeExpireIncompleteChunkedMessages`, but the autoAck is a user option in 
`removeOldestPendingChunkedMessage` and it's always true in 
`removeExpireIncompleteChunkedMessages`.
   
   ### What did you see instead?
   
   
https://github.com/apache/pulsar/blob/56c41f88600c9c1812fc9656283d159e18cad13a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L2655-L2658
   
https://github.com/apache/pulsar/blob/56c41f88600c9c1812fc9656283d159e18cad13a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L2643-L2645
   I think it's a bug that autoAck is set to true in 2658. Since user option 
`autoAckOldestChunkedMessageOnQueueFull` is already provided, why is this 
option only used for `removeOldestPendingChunkedMessage`? So I think the 
`autoAck` in `removeExpireIncompleteChunkedMessages` should be up to the user.
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to