AnonHxy commented on PR #16605: URL: https://github.com/apache/pulsar/pull/16605#issuecomment-1216503545
> but unfortunately there are still failing tests, we need all tests to pass before committing the patch OK @eolivelli . Some of the failing tests are flaky test. However the "Pulsar CI / CI - System - Sql (pull_request) " always fail in this PR but success in other PRs. It takes me some time to find the bug. Luckly we find the bug and fix it in https://github.com/apache/pulsar/pull/17093. The bug has nothing to do with this PR, but it confuses me the correctness of the modification. After https://github.com/apache/pulsar/pull/17093 merged, I will run all CI again and continue my work to make sure all tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
