codelipenghui commented on code in PR #17049:
URL: https://github.com/apache/pulsar/pull/17049#discussion_r946998918
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java:
##########
@@ -1412,22 +1424,16 @@ public void testReplicatorWithFailedAck() throws
Exception {
producer1.produce(10);
- Position deletedPos = cursor.getMarkDeletedPosition();
- Position readPos = cursor.getReadPosition();
-
- Awaitility.await().timeout(30, TimeUnit.SECONDS).until(
- () -> cursor.getMarkDeletedPosition().getEntryId() !=
(cursor.getReadPosition().getEntryId() - 1));
-
- assertNotEquals((readPos.getEntryId() - 1), deletedPos.getEntryId());
Review Comment:
Removed here because the producer might be closed with pending messages.
After the cursor change to the close state, the producer will also be closed
after a read entries failure. So that all the pending messages will fail with
the `Producer Already Closed` exception, then the cursor will rewind
https://github.com/apache/pulsar/blob/9f40cc1d1104900c450a599676ca446b1f096a00/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java#L425
This will make the check failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
