BewareMyPower commented on PR #17099:
URL: https://github.com/apache/pulsar/pull/17099#issuecomment-1217831356
I found another problem when I reviewed this PR but it's not related. I
found some versioned docs contain both `develop-binary-protocol.md` and
`developing-binary-protocol.md`. I compared these two files in `version-2.9.1`
directory (after applying changes of this PR), they are nearly the same.
```diff
2c2
< id: develop-binary-protocol
---
> id: developing-binary-protocol
5c5
< original_id: develop-binary-protocol
---
> original_id: developing-binary-protocol
400a401,425
> * `properties` → *(optional)* Reserved configuration items
> * `txnid_most_bits` → *(optional)* Same as Transaction Coordinator ID,
`txnid_most_bits` and `txnid_least_bits`
> uniquely identify a transaction.
> * `txnid_least_bits` → *(optional)* The ID of the transaction opened in a
transaction coordinator,
> `txnid_most_bits` and `txnid_least_bits`uniquely identify a transaction.
> * `request_id` → *(optional)* ID for handling response and timeout.
>
>
> ##### Command AckResponse
>
> An `AckResponse` is the broker’s response to acknowledge a request sent by
the client. It contains the `consumer_id` sent in the request.
> If a transaction is used, it contains both the Transaction ID and the
Request ID that are sent in the request. The client finishes the specific
request according to the Request ID. If the `error` field is set, it indicates
that the request has failed.
>
> An example of `AckResponse` with redirection:
>
> ```protobuf
>
> message CommandAckResponse {
> "consumer_id" : 1,
> "txnid_least_bits" = 0,
> "txnid_most_bits" = 1,
> "request_id" = 5
> }
>
> ```
461c486
< Lookup can be done with a REST call as described in the [admin
API](admin-api-topics.md#look-up-topics-owner-broker)
---
> Lookup can be done with a REST call as described in the [admin
API](admin-api-topics.md#lookup-of-topic)
```
Could we delete the develop-binary-protocol.md?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
