liangyuanpeng commented on code in PR #17078:
URL: https://github.com/apache/pulsar/pull/17078#discussion_r948611873
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/RocksdbMetadataStore.java:
##########
@@ -233,12 +240,15 @@ private RocksdbMetadataStore(String metadataURL,
MetadataStoreConfig metadataSto
throw new MetadataStoreException("Fail to create RocksDB file
directory", e);
}
+ readonly = "true".equalsIgnoreCase(
Review Comment:
My first impl version is using rocksdb config file (metadata config file)
and the `rocksdb config file` is more used to work for rocksdb core, so i
change it to system property for this config.
Do you have any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
