BewareMyPower opened a new pull request, #17162: URL: https://github.com/apache/pulsar/pull/17162
### Motivation It's a catchup for https://github.com/apache/pulsar/pull/3249. Currently C++ client doesn't have strict validation on the service URL. If multiple brokers are specified, only the 1st broker will be used. ### Modifications - Add `ServiceURI` to support configuring multiple brokers in the service URL. See `ServiceURITest` for how to configure it. - Add `ServiceNameResolver` whose `resolveHost` method selects the next broker in a round robin way. - Since the broker's address for topic lookup is no longer the service URL itself, to handle the case when proxy is enabled, a `getBroker` method (like the same method in Java's `LookupService`), which returns the future of a pair of logical and physical addresses, is added to replace `lookupAsync`. - Apply `ServiceNameResolver` into `ClientImpl` and the `LookupService` implementations. - Rename `BinaryLookupServiceTest` to `LookupServiceTest` and add `testMultiAddresses` to test both `BinaryProtoLookupService` and `HTTPLookupService` that all available brokers will be accessed in a round robin way. ### Behavior Change This PR also changes the behavior when the user passed service URL. Before this PR, creating a `Client` object will succeed but the methods to create a producer or consumer will return a failed `Result`. After this PR, an `invalid_argument` exception will be thrown. ### TODO This is the 1st part to support multiple brokers. Even with this patch, if one of these hosts is not available, the topic lookup will fail immediately instead of trying other broker. Since this patch already includes many code changes, I will push another patch to fix it. <!-- ### Contribution Checklist - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)* Fixes #<xyz> *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: #<xyz> ### Motivation *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* ### Modifications *Describe the modifications you've done.* ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
