mattisonchao opened a new pull request, #17167:
URL: https://github.com/apache/pulsar/pull/17167

   ### Motivation
   
   Pulsar has the `brokerMaxConnectionsPerIp` configuration at the
   broker, we can use it to limit the maximum connections per IP.
   
   The original motivation and PR here: 
https://github.com/apache/pulsar/pull/10754
   
   IMO, we can also apply it to pulsar-proxy, because when a large
   number of proxy accesses under the same IP (maybe due to some wrong
   operations) will cause the proxy to accept too much wrong traffic and
   cause service unstable.
   
   Discussion link: 
https://lists.apache.org/thread/co00zx8ns3ksbccxs82lfh624rx1sht6
   
   ### Modifications
   
   - Reuse `ConnectionController` for proxy part.
   - Move `ConnectionController` to `broker-common` module.
   - Add proxy configuration `maxConcurrentInboundConnectionsPerIp`
   - Send `ServerError.NotAllowedError` command to prevent client reconnecting.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [x] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to