coderzc commented on issue #16763: URL: https://github.com/apache/pulsar/issues/16763#issuecomment-1219640031
> Could you please add more context about why we need this API? to rebuild the index? It should be a risk if only clear the index without any cursor rewind or index rebuilding. The consumer will not be able to receive delayed messages, no? Oh, It only is to clear residual data after operate downgrade. > For the metrics we are using pulsar_delayed_message_index_* https://github.com/apache/pulsar/pull/15867/files#diff-b3f64ff76fdabb9e471435147298c3c707cbecae09023f0d86cf06f6ad78cbdaR352. It's better to keep the metrics name consistent. Ok, I improve it. > Is it better to split SnapshotMetadata and SnapshotData into 2 commands? It's easier to read. The metadata message have bitset and scheduleTime, the data message only has the sorted list. And we'd better change BucketSnapshotFormat.proto to DelayedMessageIndexBucketSnapshotFormat.proto Ok, I agree with it. > It's a little confusing for this one. For each bucket, we should only have one snapshot, for each entry in the snapshot, we should use a different name, snapshot record or something. > > CompletableFuture createBucket(); > I think this one is used to create a snapshot? > CompletableFuture deleteBucket(long bucketId); > is this one used to delete a snapshot? Yes, I improve method name. > What does this method really do? Does it look like initialize()? Yes, It is a initialized function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
