mattisonchao commented on code in PR #15811:
URL: https://github.com/apache/pulsar/pull/15811#discussion_r951066997
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -2928,11 +2928,20 @@ public Optional<TopicPolicies>
getTopicPolicies(TopicName topicName) {
}
public CompletableFuture<Void> deleteTopicPolicies(TopicName topicName) {
- if (!pulsar().getConfig().isTopicLevelPoliciesEnabled()) {
+ final PulsarService pulsarService = pulsar();
+ if (!pulsarService.getConfig().isTopicLevelPoliciesEnabled()) {
return CompletableFuture.completedFuture(null);
}
- TopicName cloneTopicName =
TopicName.get(topicName.getPartitionedTopicName());
- return
pulsar.getTopicPoliciesService().deleteTopicPoliciesAsync(cloneTopicName);
+ return pulsarService.getPulsarResources().getNamespaceResources()
+ .getPoliciesAsync(topicName.getNamespaceObject())
Review Comment:
We want to check if the namespace is marked as "deleted". This means the
namespace is being deleted. We don't need to delete the topic policy anymore.
If we connect to the `deleted` namespace. we will get an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
