tisonkun commented on code in PR #17208:
URL: https://github.com/apache/pulsar/pull/17208#discussion_r951243968
##########
docker/pulsar-all/pom.xml:
##########
@@ -150,46 +150,8 @@
<tag>${project.version}</tag>
</tags>
</build>
- </image>
- </images>
- </configuration>
- </execution>
- <execution>
- <id>push-latest</id>
- <goals>
- <goal>push</goal>
- </goals>
- <configuration>
- <images>
- <image>
- <name>${docker.organization}/pulsar-all</name>
- <build>
- <contextDir>${project.basedir}</contextDir>
- <tags>
- <tag>latest</tag>
- </tags>
- </build>
- </image>
- </images>
- </configuration>
- </execution>
- <execution>
- <id>add-no-repo</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- <configuration>
- <images>
- <image>
- <name>pulsar-all</name>
- <build>
- <contextDir>${project.basedir}</contextDir>
- <tags>
- <tag>latest</tag>
- <tag>${project.version}</tag>
- </tags>
- </build>
+ <tagName>latest</tagName>
+ <repo>pulsar-all</repo>
Review Comment:
You may add an execution block under `<goal>build</goal>`. Or do you verify
this patch locally? When I read the doc of dmp, it shows that `tagName` is a
top-level config instead of inside `image`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
