RobertIndie commented on code in PR #17125:
URL: https://github.com/apache/pulsar/pull/17125#discussion_r951352937
##########
pulsar-client-cpp/lib/Message.cc:
##########
@@ -223,5 +223,8 @@ PULSAR_PUBLIC std::ostream& operator<<(std::ostream& s,
const Message& msg) {
<< ", msg_id=" << msg.getMessageId() << ", props=" <<
msg.getProperties() << ')';
return s;
}
+KeyValue Message::getKeyValueData(const KeyValueEncodingType&
keyValueEncodingType) const {
+ return KeyValue(getDataAsString(), keyValueEncodingType);
Review Comment:
Here it seems to result in a data copy. We may need to use `getData` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
