MarvinCai opened a new pull request, #17212: URL: https://github.com/apache/pulsar/pull/17212
Fixes https://github.com/apache/pulsar/issues/17165 ### Motivation Fix flaky test avoidUseSameOpAddEntryBetweenDifferentLedger. ### Modifications Test case avoidUseSameOpAddEntryBetweenDifferentLedger is trying to poll data from ledger.pendingAddEntries, but when OpAddEntry is completed the callback will also poll data from ledger.pendingAddEntries, thus causing race condition. Try to move to logic of creating new OpAddEntry when switched to a different ledger to a separate method so test won't trigger actualy OpAddEntry compeltion and eliminating race condition for test. ### Verifying this change - [x] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: ( no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
