tisonkun commented on code in PR #17172:
URL: https://github.com/apache/pulsar/pull/17172#discussion_r952107099
##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java:
##########
@@ -240,8 +240,8 @@ && isBlank(starterArguments.bookieConfigFile)) {
// init bookie server
if (starterArguments.runBookie) {
- checkNotNull(bookieConfig, "No ServerConfiguration for
Bookie");
- checkNotNull(bookieStatsProvider, "No Stats Provider for
Bookie");
+ Objects.requireNonNull(bookieConfig, "No ServerConfiguration
for Bookie");
Review Comment:
I think this decision is made in
https://github.com/apache/pulsar/issues/12271 where we agree on enabling the
Modernizer plugin and this is the default settings.
Besides, Guava gradually deprecates `Lists.newArrayList` since JDK provides
it out-of-the-box. This could be the same to `chekNotNull` to
`Objects.requireNonNull`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
