mattisonchao commented on code in PR #17237:
URL: https://github.com/apache/pulsar/pull/17237#discussion_r953407731
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##########
@@ -336,25 +331,40 @@ protected void readMoreEntries(Consumer consumer) {
// consumer can be null when all consumers are disconnected from
broker.
// so skip reading more entries if currently there is no active
consumer.
if (null == consumer) {
+ if (log.isDebugEnabled()) {
+ log.debug("[{}] Skipping read for the topic, Due to the
current consumer is null", topic.getName());
+ }
+ return;
+ }
+ if (havePendingRead) {
+ if (log.isDebugEnabled()) {
+ log.debug("[{}] Skipping read for the topic, Due to we have
pending read.", topic.getName());
+ }
return;
}
if (consumer.getAvailablePermits() > 0) {
- Pair<Integer, Long> calculateResult = calculateToRead(consumer);
- int messagesToRead = calculateResult.getLeft();
- long bytesToRead = calculateResult.getRight();
+ synchronized (this) {
Review Comment:
Move lock here to avoid invoking useless `calculateToRead` many times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
