cbornet commented on code in PR #16740:
URL: https://github.com/apache/pulsar/pull/16740#discussion_r954678531


##########
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java:
##########
@@ -881,4 +963,98 @@ private void setupOutput(ContextImpl contextImpl) throws 
Exception {
             
Thread.currentThread().setContextClassLoader(this.instanceClassLoader);
         }
     }
+
+    private static <T> Schema<T> getSinkSchema(Record<?> record, Class<T> 
clazz) {

Review Comment:
   We're doing these methods bc we don't have a topic. So it feels weird to put 
these in a class named `TopicSchema`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to