jiazhai commented on a change in pull request #4157:
[Issue#2734][pulsar-brokers]Add namespace level enforcement on schema validation
URL: https://github.com/apache/pulsar/pull/4157#discussion_r279238176
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
##########
@@ -843,5 +843,37 @@ public void
setSchemaAutoUpdateCompatibilityStrategy(@PathParam("tenant") String
internalSetSchemaAutoUpdateCompatibilityStrategy(strategy);
}
+ @GET
+ @Path("/{tenant}/{namespace}/schemaValidationEnforced")
+ @ApiOperation(value = "Get schema validation enforced flag for namespace.
If the flag is set to true, when "
+ + " a producer without a schema attempts to
produce to a topic with schema in this"
+ + " the namespace, the producer will be failed to
connect. PLEASE be carefully on"
Review comment:
remove "the" before "namespace", since we have "this" before.
also how about split "value" into "value" and "notes" as line 832?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
