congbobo184 opened a new pull request, #17287:
URL: https://github.com/apache/pulsar/pull/17287
issue:
after set dead letter maxRedeliverCount(1), when txn ack abort, the messages
will keep receiving. because, now the message send to dead letter topic should
invoke `redeliver` or `doReconsumeLater`. but in this case, users haven't
invoked redeliver, the message will keep receiving
reproduce:
1. set dead letter maxRedeliverCount(1)
2. receive a message
3. ack message with txn
4. abort
5. keep receiving this message
### Motivation
when reach maxRedeliverCount(1), send the message to DLQ. the current
consumer can't receive this message again
### Modification
```
redeliveryCount > deadLetterPolicy.getMaxRedeliverCount()
```
send this message to DLQ directly
### Verifying this change
add the test
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
