lhotari commented on code in PR #17297:
URL: https://github.com/apache/pulsar/pull/17297#discussion_r955966627
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java:
##########
@@ -220,7 +220,7 @@ public OpSendMsg createOpSendMsg() throws IOException {
messageMetadata.copyFrom(messages.get(0).getMessageBuilder());
ByteBuf encryptedPayload =
producer.encryptMessage(messageMetadata,
getCompressedBatchMetadataAndPayload());
ByteBufPair cmd = producer.sendMessage(producer.producerId,
messageMetadata.getSequenceId(),
- 1, messageMetadata, encryptedPayload);
+ 1, messages.get(0).getMessageId(), messageMetadata,
encryptedPayload);
Review Comment:
This doesn't look right. Are you sure that this is the correct way to fix
this?
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java:
##########
@@ -220,7 +220,7 @@ public OpSendMsg createOpSendMsg() throws IOException {
messageMetadata.copyFrom(messages.get(0).getMessageBuilder());
ByteBuf encryptedPayload =
producer.encryptMessage(messageMetadata,
getCompressedBatchMetadataAndPayload());
ByteBufPair cmd = producer.sendMessage(producer.producerId,
messageMetadata.getSequenceId(),
- 1, messageMetadata, encryptedPayload);
+ 1, messages.get(0).getMessageId(), messageMetadata,
encryptedPayload);
Review Comment:
See #17195 . PIP-180 is for the shadow replicator. `null` should be passed
here. I created another PR #17300 since I didn't notice this PR and I digged
the reason why things broke.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
