AnonHxy commented on code in PR #17314:
URL: https://github.com/apache/pulsar/pull/17314#discussion_r956690091
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -817,6 +817,17 @@ protected void handleConnect(CommandConnect connect) {
return;
}
+ if (!this.service.getPulsar().isRunning()) {
Review Comment:
If `!service.isAuthenticationEnabled()` return true, the connect will
complete without checking pulsar service is running or not.
My suggestion is that move this code block just to Line807, which is just
below the debug log @HQebupt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
