sijie commented on issue #4166: Rename package to avoid java-module-system split-package issue URL: https://github.com/apache/pulsar/pull/4166#issuecomment-487582589 > The pulsar-client-all module adds exactly the same two dependencies as I did myself in my application I am not sure about that. `pulsar-client-all` module is a shaded module that package all the dependencies and shade them. so it would be treated as one module though and there is no transitive dependency shared by two modules. unless I missed something from your description. > How about my other suggestions in my previous comment? I am not sure about merging pulsar-common to pulsar-client-common. that means the modules depend on pulsar-common now have to depend on pulsar-client-common. I really don't think it is a good idea though, unless there is really strong reason to do so.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
